Skip to content

[ci] Fix some web-platform_tests. #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 25, 2023

Conversation

ditman
Copy link
Member

@ditman ditman commented Feb 23, 2023

This PR does three things:

  • Re-enables url_launcher_web testing in web-platform_tests in the stable channel.
  • Fixes the tests that were failing in url_launcher_web by adding an "await" on the tester in between tests (this is odd, and only required in stable with Chrome 98, so there might be some weird interaction with that combination)
  • Fixes a google_maps_web test that started failing. It seems that we used to be able to move the "center" of a Map that was being mocked, but now it seems that the map needs a proper projection. Moved the failing test case to a test that has an actual map widget being rendered.

Fixes flutter/flutter#121161

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman force-pushed the link-widget-test-stable branch from 5b8dae1 to 4d78fd8 Compare February 24, 2023 21:30
@ditman ditman changed the title [ci] Re-enable url_launcher_web web-platform_tests in stable. [ci] Fix some web-platform_tests. Feb 24, 2023
@ditman ditman marked this pull request as ready for review February 25, 2023 00:01
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2023
@auto-submit auto-submit bot merged commit 2e04050 into flutter:main Feb 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 28, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
[ci] Fix some web-platform_tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter p: url_launcher platform-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[url_launcher] link_widget_test.dart test failing on stable
2 participants